Issue 25411004: Polymorphic inlining for []= operators.

Issue 25411004: Polymorphic inlining for []= operators. (Closed)

Created:
7 years, 2 months ago by Florian Schneider

Modified:
7 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Polymorphic inlining for []= operators. This CL allows the inliner to do polymorphic inlining of recognized []= operators. Before, only monomorphic calls were handled in the optimizer. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28202

Patch Set 1 #

Patch Set 2 : fixed checked mode #

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+333 lines, -293 lines)			Patch
M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1	3 chunks	+23 lines, -12 lines	4 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	11 chunks	+292 lines, -280 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

On 2013/10/02 15:13:10, Florian Schneider wrote: Keep this on hold until I fixed a checked-mode ...

7 years, 2 months ago (2013-10-02 15:34:31 UTC) #2

Florian Schneider

Ready for review. Uploaded new patch with the checked-mode bug fixed.

7 years, 2 months ago (2013-10-02 15:46:00 UTC) #3

srdjan

lgtm https://codereview.chromium.org/25411004/diff/9001/runtime/vm/flow_graph_optimizer.h File runtime/vm/flow_graph_optimizer.h (right): https://codereview.chromium.org/25411004/diff/9001/runtime/vm/flow_graph_optimizer.h#newcode84 runtime/vm/flow_graph_optimizer.h:84: Definition** last); It would be nice if we ...

7 years, 2 months ago (2013-10-02 16:19:19 UTC) #4

Florian Schneider

https://codereview.chromium.org/25411004/diff/9001/runtime/vm/flow_graph_optimizer.h File runtime/vm/flow_graph_optimizer.h (right): https://codereview.chromium.org/25411004/diff/9001/runtime/vm/flow_graph_optimizer.h#newcode84 runtime/vm/flow_graph_optimizer.h:84: Definition** last); On 2013/10/02 16:19:19, srdjan wrote: > It ...

7 years, 2 months ago (2013-10-03 09:20:52 UTC) #5

Florian Schneider

7 years, 2 months ago (2013-10-03 09:43:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r28202 (presubmit successful).

Expand Messages | Collapse Messages