Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 25405002: Remove NPObject from generated dart:html for Dartium. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove NPObject from generated dart:html for Dartium. R=asiva@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28117

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +0 lines, -34 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/dom/src/native_DOMPublic.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-01 00:35:31 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-01 16:03:23 UTC) #2
vsm
lgtm
7 years, 2 months ago (2013-10-01 16:49:06 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-01 20:51:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698