Issue 25404004: Avoid using stdioType in unittest to work around issue 13712.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25404004: Avoid using stdioType in unittest to work around issue 13712. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid using stdioType in unittest to work around issue 13712. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28077

Patch Set 2 : Code review change. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pkg/unittest/lib/vm_config.dart	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm. one nit https://codereview.chromium.org/25404004/diff/1/pkg/unittest/lib/vm_config.dart File pkg/unittest/lib/vm_config.dart (right): https://codereview.chromium.org/25404004/diff/1/pkg/unittest/lib/vm_config.dart#newcode26 pkg/unittest/lib/vm_config.dart:26: // TODO(nweiz): re-enable this when issue ...

7 years, 2 months ago (2013-10-01 00:52:39 UTC) #2

nweiz

https://codereview.chromium.org/25404004/diff/1/pkg/unittest/lib/vm_config.dart File pkg/unittest/lib/vm_config.dart (right): https://codereview.chromium.org/25404004/diff/1/pkg/unittest/lib/vm_config.dart#newcode26 pkg/unittest/lib/vm_config.dart:26: // TODO(nweiz): re-enable this when issue 13712 is fixed. ...

7 years, 2 months ago (2013-10-01 00:53:40 UTC) #3

nweiz

7 years, 2 months ago (2013-10-01 00:53:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28077 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25404004: Avoid using stdioType in unittest to work around issue 13712. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change. #

Messages