Issue 25392003: TBR: fix build break

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25392003: TBR: fix build break (Closed)

Created:
7 years, 2 months ago by Jacob

Modified:
7 years, 2 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

TBR: fix build break BUG= Committed: https://code.google.com/p/dart/source/detail?r=28075

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/object.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

Not sure why I don't get an error when I build DartVM locally but I ...

7 years, 2 months ago (2013-10-01 00:27:14 UTC) #1

Jacob

Committed patchset #1 manually as r28075 (presubmit successful).

7 years, 2 months ago (2013-10-01 00:27:54 UTC) #2

Ivan Posva

https://codereview.chromium.org/25392003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/25392003/diff/1/runtime/vm/object.cc#newcode13683 runtime/vm/object.cc:13683: return OneByteString::New(static_cast<intptr_t>(0), Heap::kNew); Why are you not returning the ...

7 years, 2 months ago (2013-10-01 00:31:50 UTC) #3

hausner

7 years, 2 months ago (2013-10-01 03:02:58 UTC) #4

Message was sent while issue was closed.

I am confused about patch set 2. It's a different change altogether. Regarding
patch set 1: what Ivan said. And I don't understand the static_cast either, I
don't think it should be necessary.

Expand Messages | Collapse Messages