Issue 25385004: Fix pub to work with new Directory.createSystemTemp.

Issue 25385004: Fix pub to work with new Directory.createSystemTemp. (Closed)

Created:
7 years, 2 months ago by Bill Hesse

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom, kustermann

CC:
reviews_dartlang.org, Bob Nystrom, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix pub to work with new Directory.createSystemTemp. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=28101

Patch Set 1 #

Total comments: 6

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/io.dart	View	2 chunks	+10 lines, -3 lines	6 comments	Download
M	sdk/lib/_internal/pub/lib/src/system_cache.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/test_pub.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #1 manually as r28101 (presubmit successful).

7 years, 2 months ago (2013-10-01 16:39:54 UTC) #3

Bob Nystrom

https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode235 sdk/lib/_internal/pub/lib/src/io.dart:235: String createTempDir(String base, String prefix) { Is it a ...

7 years, 2 months ago (2013-10-01 17:37:02 UTC) #4

Bill Hesse

7 years, 2 months ago (2013-10-02 13:25:05 UTC) #5

Message was sent while issue was closed.

The requested changes are being made as part of
https://codereview.chromium.org/25720002/

https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:235: String createTempDir(String base,
String prefix) {
On 2013/10/01 17:37:03, Bob Nystrom wrote:
> Is it a prefix or a suffix? The doc says one thing and the parameter says
> another.

It is a prefix.  Fixed the doc comment.

https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:241: String createSystemTempDir() {
On 2013/10/01 17:37:03, Bob Nystrom wrote:
> Doc comment. Or just combine this with the above method by making both
> parameters optional.

Done.

https://codereview.chromium.org/25385004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:246: 
On 2013/10/01 17:37:03, Bob Nystrom wrote:
> Remove extra blank line.

Done.

Expand Messages | Collapse Messages