Issue 25373004: Don't throw SocketExceptions in websocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25373004: Don't throw SocketExceptions in websocket. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't throw SocketExceptions in websocket. This makes the implementation much more stable and act just like HttpResponse. BUG=https://code.google.com/p/dart/issues/detail?id=13164 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28089

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -33 lines)			Patch
	M	sdk/lib/io/websocket_impl.dart	View		8 chunks	+56 lines, -33 lines	0 comments	Download
	A	tests/standalone/io/web_socket_error_test.dart	View	1 2	1 chunk	+105 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Søren Gjesse

lgtm Will it be difficult to add any additional tests which would fail before this ...

7 years, 2 months ago (2013-10-01 10:50:40 UTC) #2

Anders Johnsen

7 years, 2 months ago (2013-10-01 11:27:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r28089 (presubmit successful).