Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 25361002: Reverts change to debug_lib.dart (Closed)

Created:
7 years, 2 months ago by zra
Modified:
7 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reverts change to debug_lib.dart Even though this behavior hid failures on ARM and MIPS, it appears that some test rely on it. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/debugger/debug_lib.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
7 years, 2 months ago (2013-09-30 22:07:30 UTC) #1
regis
LGTM
7 years, 2 months ago (2013-09-30 22:09:13 UTC) #2
zra
Committed patchset #1 manually as r28070 (presubmit successful).
7 years, 2 months ago (2013-09-30 22:11:49 UTC) #3
Florian Schneider
On 2013/09/30 22:07:30, zra wrote: This way we won't get full coverage for the other ...
7 years, 2 months ago (2013-10-01 09:15:30 UTC) #4
zra
7 years, 2 months ago (2013-10-01 14:47:33 UTC) #5
Message was sent while issue was closed.
On 2013/10/01 09:15:30, Florian Schneider wrote:
> On 2013/09/30 22:07:30, zra wrote:
> 
> This way we won't get full coverage for the other debugger tests. Wouldn't it
be
> easier to just mark the test as failing until it is fixed?

Since the failure appears to be somewhat timing dependent, and since I am
unfamiliar with the debugger tests, it would be a process of trail-and-error
figuring out which tests to mark as failing. Instead, I have created Issue
13721.

Powered by Google App Engine
This is Rietveld 408576698