Issue 25354002: Fixed x64 assembler tests that load large immediates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25354002: Fixed x64 assembler tests that load large immediates. (Closed)

Created:
7 years, 2 months ago by zra

Modified:
7 years, 2 months ago

Reviewers:
srdjan, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fixed x64 assembler tests that load large immediates. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28069

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	runtime/vm/assembler_x64_test.cc	View		5 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

zra

These were failing only on mac because stack addresses were > 32-bits. The constants are ...

7 years, 2 months ago (2013-09-30 21:52:50 UTC) #1

siva

LGTM. I am wondering if it would make sense to uniformly setup the PP always ...

7 years, 2 months ago (2013-09-30 22:04:32 UTC) #3

zra

On 2013/09/30 22:04:32, siva wrote: > LGTM. > > I am wondering if it would ...

7 years, 2 months ago (2013-09-30 22:08:41 UTC) #4

zra

7 years, 2 months ago (2013-09-30 22:11:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r28069 (presubmit successful).