Flow control structure formatting (a la the Style Guide).

Flow control structure formatting (a la the Style Guide).

Enforces the 'curly braces for all flow control structures (modulo ifs with no elses)' edict from here:

https://www.dartlang.org/articles/style-guide/#whitespace

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28072

[Brian Wilkerson, 2013-09-30 22:19:34]

LGTM

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:199: if
(!isEOF(token2) && !isCLOSE_CURLY_BRACKET(token2)) {
Do you need to check that the token following the closing curly bracket is an
EOF token?

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:322: static bool
isSynthetic(Token token) => token.offset == SYNTH_OFFSET;
It's a little unfortunate that you have a helper method when Token already has
an "isSynthetic" method. Unfortunately, the only way you could use the method
defined on token is by defining a new class:

class SyntheticToken extends StringToken {
  SyntheticToken(TokenType type, String value) : super(type, value, 0);
  int get length => 0;
}

[pquitslund, 2013-09-30 22:41:56]

Thanks!

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:199: if
(!isEOF(token2) && !isCLOSE_CURLY_BRACKET(token2)) {
On 2013/09/30 22:19:34, Brian Wilkerson wrote:
> Do you need to check that the token following the closing curly bracket is an
> EOF token?

Done.

https://codereview.chromium.org/25350003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:322: static bool
isSynthetic(Token token) => token.offset == SYNTH_OFFSET;
On 2013/09/30 22:19:34, Brian Wilkerson wrote:
> It's a little unfortunate that you have a helper method when Token already has
> an "isSynthetic" method. Unfortunately, the only way you could use the method
> defined on token is by defining a new class:
> 
> class SyntheticToken extends StringToken {
>   SyntheticToken(TokenType type, String value) : super(type, value, 0);
>   int get length => 0;
> }

Totally.  As per our conversation, we'd have to add extra checks to make sure we
weren't matching other synthetic tokens such as EOFs...

[pquitslund, 2013-09-30 22:43:48]

Committed patchset #2 manually as r28072 (presubmit successful).