- Account for live size in marker.

- Account for live size in marker.

R=koda@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35413

[koda, 2014-04-24 23:09:56]

LGTM with comments

https://codereview.chromium.org/253493002/diff/1/runtime/vm/gc_sweeper.cc
File runtime/vm/gc_sweeper.cc (right):

https://codereview.chromium.org/253493002/diff/1/runtime/vm/gc_sweeper.cc#new...
runtime/vm/gc_sweeper.cc:15: // Keep track of the discovered live object sizes
to be able to finish
Update comment; we are not tracking sizes here.

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc#newcode538
runtime/vm/pages.cc:538: usage_.used_in_words = 0;
This should be redundant now; remove.

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc#newcode561
runtime/vm/pages.cc:561: if (sweeper.SweepPage(page, &freelist_[page->type()]))
{
Consider helping the reader remember what the return value means:

bool page_in_use = ...
if (page_in_use) {
...

[Ivan Posva, 2014-04-24 23:17:50]

https://codereview.chromium.org/253493002/diff/1/runtime/vm/gc_sweeper.cc
File runtime/vm/gc_sweeper.cc (right):

https://codereview.chromium.org/253493002/diff/1/runtime/vm/gc_sweeper.cc#new...
runtime/vm/gc_sweeper.cc:15: // Keep track of the discovered live object sizes
to be able to finish
On 2014/04/24 23:09:56, koda wrote:
> Update comment; we are not tracking sizes here.

Done.

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc#newcode538
runtime/vm/pages.cc:538: usage_.used_in_words = 0;
On 2014/04/24 23:09:56, koda wrote:
> This should be redundant now; remove.

Done.

https://codereview.chromium.org/253493002/diff/1/runtime/vm/pages.cc#newcode561
runtime/vm/pages.cc:561: if (sweeper.SweepPage(page, &freelist_[page->type()]))
{
On 2014/04/24 23:09:56, koda wrote:
> Consider helping the reader remember what the return value means:
> 
> bool page_in_use = ...
> if (page_in_use) {
> ...

Done.

[Ivan Posva, 2014-04-24 23:20:53]

Committed patchset #2 manually as r35413 (presubmit successful).