Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 25344002: Fix crashing bug due to the fact that external one byte strings cannot be escaped (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, vsm
Visibility:
Public.

Description

Fix for issue where external one byte strings cannot be escaped. This occured in practice when requesting all library names for a Polymer.dart example The likely reason why the issue occurs in this case but not others is that some of the libraries are generated using data urls. Added some tests for EscapeSpecialCharacters as it did not have any tests. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=28073

Patch Set 1 #

Total comments: 4

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -6 lines) Patch
M runtime/vm/object.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +45 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 1 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
I'm not sure who the right person on the VM team is to review this. ...
7 years, 2 months ago (2013-09-30 21:07:57 UTC) #1
hausner
LGTM with comments https://codereview.chromium.org/25344002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/25344002/diff/1/runtime/vm/object.cc#newcode13691 runtime/vm/object.cc:13691: intptr_t index = 0; declare index ...
7 years, 2 months ago (2013-09-30 22:54:37 UTC) #2
Jacob
https://codereview.chromium.org/25344002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/25344002/diff/1/runtime/vm/object.cc#newcode13691 runtime/vm/object.cc:13691: intptr_t index = 0; On 2013/09/30 22:54:37, hausner wrote: ...
7 years, 2 months ago (2013-09-30 23:53:27 UTC) #3
Jacob
7 years, 2 months ago (2013-10-01 00:08:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28073 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698