Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Issue 25304002: Unwanted field shadowing fix. (Closed)

Created:
7 years, 2 months ago by pquitslund
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Inspired by the conversation on this review: https://codereview.chromium.org/24488004/ Here's a proposed fix. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=28068

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
7 years, 2 months ago (2013-09-30 17:21:55 UTC) #1
pquitslund
7 years, 2 months ago (2013-09-30 19:24:49 UTC) #2
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-09-30 21:36:27 UTC) #3
pquitslund
7 years, 2 months ago (2013-09-30 21:39:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28068 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698