Add flag —source-lines which emits appropriate source lines as code comments. Added token_pos to …

Add flag —source-lines which emits appropriate source lines as code comments. Added token_pos to some instructions. This is work in progress.

R=fschneider@google.com, johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35599

[srdjan, 2014-04-29 19:05:04]

This CL is ready for review. Thank you.

[Cutch, 2014-04-29 19:50:52]

lgtm. Let's keep adding token positions to the flow graph.

[Florian Schneider, 2014-04-29 20:04:21]

lgtm

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/flow_graph_op...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/flow_graph_op...
runtime/vm/flow_graph_optimizer.cc:8949: if (!current->CanDeoptimize() &&
!FLAG_source_lines) {
Note that this flag changes the number of uses for values used in the
environment. Therefore, it may affect performance of generated code. This is
fine since the flag is not on by default, but should be kept in mind.

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h
File runtime/vm/token.h (right):

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h#newco...
runtime/vm/token.h:322: const int kNoTokenPos = -1;
We also have Scanner::kNoSourcePos which is 0. Do you need a second constant, or
can we keep only one around?

[Cutch, 2014-04-29 20:05:24]

changing my lgtm to a conditional lgtm that we only have one kNoTokenPos

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h
File runtime/vm/token.h (right):

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h#newco...
runtime/vm/token.h:322: const int kNoTokenPos = -1;
On 2014/04/29 20:04:21, Florian Schneider wrote:
> We also have Scanner::kNoSourcePos which is 0. Do you need a second constant,
or
> can we keep only one around?

Good catch. Let's only have one.

[srdjan, 2014-04-30 15:00:51]

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/flow_graph_op...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/flow_graph_op...
runtime/vm/flow_graph_optimizer.cc:8949: if (!current->CanDeoptimize() &&
!FLAG_source_lines) {
On 2014/04/29 20:04:21, Florian Schneider wrote:
> Note that this flag changes the number of uses for values used in the
> environment. Therefore, it may affect performance of generated code. This is
> fine since the flag is not on by default, but should be kept in mind.

Removed since it changes code.

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h
File runtime/vm/token.h (right):

https://codereview.chromium.org/253013006/diff/60001/runtime/vm/token.h#newco...
runtime/vm/token.h:322: const int kNoTokenPos = -1;
On 2014/04/29 20:04:21, Florian Schneider wrote:
> We also have Scanner::kNoSourcePos which is 0. Do you need a second constant,
or
> can we keep only one around?

Removed kNoTokenPos

[srdjan, 2014-04-30 21:18:18]

Committed patchset #8 manually as r35599 (presubmit successful).