Issue 25290002: Format selection preservation editor bits.

Issue 25290002: Format selection preservation editor bits. (Closed)

Created:
7 years, 2 months ago by pquitslund

Modified:
7 years, 2 months ago

Reviewers:
devoncarew, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Format selection preservation editor bits. R=brianwilkerson@google.com, devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=28061

Patch Set 5 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -11 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java	View	1 2 3 4	4 chunks	+44 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java	View	1 2	2 chunks	+19 lines, -3 lines	0 comments	Download
M	pkg/analyzer_experimental/bin/formatter.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/25290002/diff/7001/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java (right): https://codereview.chromium.org/25290002/diff/7001/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java#newcode90 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java:90: * Holder for fomatted source and selection info. ...

7 years, 2 months ago (2013-09-30 16:35:23 UTC) #2

pquitslund

Thanks! https://codereview.chromium.org/25290002/diff/7001/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java (right): https://codereview.chromium.org/25290002/diff/7001/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java#newcode90 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java:90: * Holder for fomatted source and selection info. ...

7 years, 2 months ago (2013-09-30 17:00:24 UTC) #4

pquitslund

7 years, 2 months ago (2013-09-30 17:02:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r28061 (presubmit successful).

Expand Messages | Collapse Messages