Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 252893002: Fix registration of closure functions (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix registration of closure functions Closure functions get registered in the class by the compiler backend. The incorrect assumption was that each closure only gets visited once. However, closures in finally clauses are duplicated when the AST nodes of the finally clause are inlined. This change avoids the duplicate registration. Fixes issue 18225 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35487

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +16 lines, -14 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 7 months ago (2014-04-28 17:13:39 UTC) #1
srdjan
lgtm
6 years, 7 months ago (2014-04-28 17:18:58 UTC) #2
hausner
6 years, 7 months ago (2014-04-28 17:20:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698