Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 252853002: Add support for running debug mode pkg, docs tests (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for running debug mode pkg, docs tests Currently disable pub tests in debug, see issue 18479 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35479

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M tools/bots/pub.py View 3 chunks +11 lines, -7 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 8 months ago (2014-04-28 10:34:03 UTC) #1
ricow1
6 years, 8 months ago (2014-04-28 10:34:14 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/252853002/diff/1/tools/bots/pub.py File tools/bots/pub.py (right): https://codereview.chromium.org/252853002/diff/1/tools/bots/pub.py#newcode51 tools/bots/pub.py:51: # Pub tests currently has a lot of ...
6 years, 8 months ago (2014-04-28 10:53:43 UTC) #3
ricow1
6 years, 8 months ago (2014-04-28 11:05:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698