Issue 25284003: Fix expression evaluation in library context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25284003: Fix expression evaluation in library context (Closed)

Created:
7 years, 2 months ago by hausner

Modified:
7 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix expression evaluation in library context - Use correct source for patch functions when class finalizer reports error - Reinstate support for class in Dart_EvaluateExpr R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28064

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -44 lines)			Patch
M	runtime/vm/class_finalizer.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	10 chunks	+13 lines, -12 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	10 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

7 years, 2 months ago (2013-09-30 18:49:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28064 (presubmit successful).