Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25279003: dart:io | Add Directory.CreateSystemTemp(template) and change Directory.CreateTemp(template). (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

dart:io | Add Directory.CreateSystemTemp(template) and change Directory.CreateTemp(template). BUG=dartbug.com/12496 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28097

Patch Set 1 #

Patch Set 2 : Add implementation on all platforms. #

Patch Set 3 : Move changes to tests to a separate CL. #

Patch Set 4 : Fix test. #

Patch Set 5 : Add deadline for removing compatibility mode. #

Total comments: 2

Patch Set 6 : Add check of "TMP" environment variable if "TMPDIR" is missing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -71 lines) Patch
M runtime/bin/builtin_natives.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/directory.cc View 1 4 chunks +27 lines, -2 lines 0 comments Download
M runtime/bin/directory_android.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 2 3 4 5 2 chunks +16 lines, -6 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 2 3 4 5 2 chunks +16 lines, -7 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/directory_win.cc View 1 2 3 4 5 2 chunks +8 lines, -13 lines 0 comments Download
M runtime/bin/io_service.h View 3 chunks +7 lines, -6 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/directory.dart View 1 1 chunk +46 lines, -12 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 4 3 chunks +46 lines, -6 lines 0 comments Download
M sdk/lib/io/io_service.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
https://codereview.chromium.org/25279003/diff/10001/runtime/bin/directory.cc File runtime/bin/directory.cc (right): https://codereview.chromium.org/25279003/diff/10001/runtime/bin/directory.cc#newcode84 runtime/bin/directory.cc:84: "Template argument of CreateSystemTempSync is not a String")); Only ...
7 years, 2 months ago (2013-10-01 13:27:27 UTC) #1
Søren Gjesse
LGTM https://codereview.chromium.org/25279003/diff/10001/runtime/bin/directory_linux.cc File runtime/bin/directory_linux.cc (right): https://codereview.chromium.org/25279003/diff/10001/runtime/bin/directory_linux.cc#newcode383 runtime/bin/directory_linux.cc:383: const char* temp_dir = getenv("TMPDIR"); Should we check ...
7 years, 2 months ago (2013-10-01 14:28:46 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-10-01 15:39:18 UTC) #3
Message was sent while issue was closed. 
Committed patchset #6 manually as r28097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698