Issue 252723002: Comment out generated resolver tests (TBR).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252723002: Comment out generated resolver tests (TBR). (Closed)

Created:
6 years, 8 months ago by Paul Berry

Modified:
6 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Comment out generated resolver tests (TBR). Committed: https://code.google.com/p/dart/source/detail?r=35427

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+28 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as r35427 (presubmit successful).

6 years, 8 months ago (2014-04-25 15:38:48 UTC) #1

Brian Wilkerson

LGTM, but why did we need to comment them out and what do we need ...

6 years, 8 months ago (2014-04-26 16:05:50 UTC) #2

Paul Berry

6 years, 7 months ago (2014-04-28 16:36:51 UTC) #3

Message was sent while issue was closed.

On 2014/04/26 16:05:50, Brian Wilkerson wrote:
> LGTM, but why did we need to comment them out and what do we need to do to get
> them running?

On some buildbots it takes longer than one minute to run all the tests in
resolver_test.dart, causing timeout errors.  We could probably fix this by, for
example, teaching the translator to put each call to .dartSuite() in its own
_test.dart file.  Let's talk about it sometime this week.

Expand Messages | Collapse Messages