Issue 252693003: Allow a closure to be torn off from itself via .call.

Issue 252693003: Allow a closure to be torn off from itself via .call. (Closed)

Created:
6 years, 8 months ago by herhut

Modified:
6 years, 8 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow a closure to be torn off from itself via .call. BUG= http://dartbug.com/17474 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=35473

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -1 line)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1 chunk	+7 lines, -0 lines	1 comment	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

herhut

Committed patchset #1 manually as r35473 (presubmit successful).

6 years, 8 months ago (2014-04-28 06:47:21 UTC) #3

karlklose

https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart (right): https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart#newcode51 sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:51: // We add a special getter here to allow ...

6 years, 8 months ago (2014-04-28 07:04:22 UTC) #4

herhut

6 years, 8 months ago (2014-04-28 09:08:23 UTC) #5

Message was sent while issue was closed.

On 2014/04/28 07:04:22, karlklose wrote:
>
https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/compiler/i...
> File sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
> (right):
> 
>
https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/compiler/i...
> sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:51: //
> We add a special getter here to allow for tearing off a closure form
> 'form' -> 'from'.
> 
>
https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/lib/js_hel...
> File sdk/lib/_internal/lib/js_helper.dart (right):
> 
>
https://codereview.chromium.org/252693003/diff/1/sdk/lib/_internal/lib/js_hel...
> sdk/lib/_internal/lib/js_helper.dart:2266: // not want this getter to be
> visisble to resolution and the generation of
> 'visisble' -> 'visible'.
> 
> Please add that we comment this method out on purpose (because we don't want
it
> to be visible).
> 
> Remove 'Note that'?

I have addressed these in https://codereview.chromium.org/253753002/

Expand Messages | Collapse Messages