Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2526633002: Support generic methods. Fix #556. (Closed)

Created:
4 years ago by Bob Nystrom
Modified:
4 years ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into generic-methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -21 lines) Patch
M CHANGELOG.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/argument_list_visitor.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M lib/src/call_chain_visitor.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M lib/src/dart_formatter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 5 chunks +30 lines, -4 lines 0 comments Download
M pubspec.lock View 5 chunks +7 lines, -7 lines 0 comments Download
A test/splitting/generic_method_arguments.stmt View 1 chunk +71 lines, -0 lines 0 comments Download
M test/splitting/type_arguments.stmt View 1 chunk +21 lines, -1 line 0 comments Download
M test/whitespace/expressions.stmt View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years ago (2016-11-22 23:11:24 UTC) #2
kevmoo
lgtm
4 years ago (2016-11-22 23:26:38 UTC) #3
Bob Nystrom
4 years ago (2016-11-22 23:46:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f4eda518bdac416a85efac81d363b842e6a97e8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698