Issue 252583006: Move conditional skip after unconditional skips

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252583006: Move conditional skip after unconditional skips (Closed)

Created:
6 years, 8 months ago by vsm

Modified:
6 years, 8 months ago

Reviewers:
Leaf, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move conditional skip after unconditional skips TBR=iposva@google.com,leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=35449

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/pkg.status	View		2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #1 manually as r35449 (presubmit successful).

6 years, 8 months ago (2014-04-25 21:42:11 UTC) #1

Ivan Posva

6 years, 8 months ago (2014-04-25 22:00:04 UTC) #2

Message was sent while issue was closed.

LGTM -ip

https://codereview.chromium.org/252583006/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/252583006/diff/1/pkg/pkg.status#newcode21
pkg/pkg.status:21: [ $runtime == vm ]
Thanks! The comments confused me, sorry.

Expand Messages | Collapse Messages