Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2525553003: Tighten the span around index operators. (Closed)

Created:
4 years, 1 month ago by Bob Nystrom
Modified:
4 years, 1 month ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tighten the span around index operators. Splitting after "[" rarely looks good. Trying this out on a real corpus seems to improve every affected case I saw. R=kevmoo@google.com Committed: https://github.com/dart-lang/dart_style/commit/19a3a7cafdd121f7f1c535e26a094611edaf9b19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/chunk.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/regression/other/angular.unit View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 1 month ago (2016-11-22 23:00:16 UTC) #2
kevmoo
lgtm
4 years, 1 month ago (2016-11-22 23:02:56 UTC) #3
Bob Nystrom
4 years, 1 month ago (2016-11-22 23:12:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19a3a7cafdd121f7f1c535e26a094611edaf9b19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698