Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 25251003: Allow import/export of libraries with no name. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow import/export of libraries with no name. BUG=http://dartbug.com/11475 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28049 Committed: https://code.google.com/p/dart/source/detail?r=28079

Patch Set 1 #

Patch Set 2 : Update status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 3 chunks +8 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-09-30 11:42:17 UTC) #1
kasperl
LGTM. Do we still fail if we try to import a part (marked with 'part ...
7 years, 2 months ago (2013-09-30 11:43:49 UTC) #2
Johnni Winther
On 2013/09/30 11:43:49, kasperl wrote: > LGTM. Do we still fail if we try to ...
7 years, 2 months ago (2013-09-30 12:15:32 UTC) #3
Johnni Winther
Committed patchset #1 manually as r28049 (presubmit successful).
7 years, 2 months ago (2013-09-30 12:18:34 UTC) #4
Johnni Winther
7 years, 2 months ago (2013-10-01 08:35:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r28079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698