Typed mocks library.

Typed mocks library.

R=danrubel@google.com, brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=35399

[danrubel, 2014-04-24 14:06:02]

Interesting. LGTM.

[devoncarew, 2014-04-24 16:31:50]

https://codereview.chromium.org/252463002/diff/1/pkg/analysis_server/test/typ...
File pkg/analysis_server/test/typed_mock.dart (right):

https://codereview.chromium.org/252463002/diff/1/pkg/analysis_server/test/typ...
pkg/analysis_server/test/typed_mock.dart:45: Behavior then(Function function) {
Uses of this method end up looking a lot like a Future result:

  when(obj.testProperty).then(() => 123);

I wonder if changing the name would help? thenFunction()? Or changing the prefix
for the methods? So, mockReturn() and mockThrow, or, doReturn() and doThrow().

[scheglov, 2014-04-24 16:44:20]

https://codereview.chromium.org/252463002/diff/1/pkg/analysis_server/test/typ...
File pkg/analysis_server/test/typed_mock.dart (right):

https://codereview.chromium.org/252463002/diff/1/pkg/analysis_server/test/typ...
pkg/analysis_server/test/typed_mock.dart:45: Behavior then(Function function) {
On 2014/04/24 16:31:50, devoncarew wrote:
> Uses of this method end up looking a lot like a Future result:
> 
>   when(obj.testProperty).then(() => 123);

  Does Future has an exclusive right on "then" name? :-)

> 
> I wonder if changing the name would help? thenFunction()? Or changing the
prefix
> for the methods? So, mockReturn() and mockThrow, or, doReturn() and doThrow().

Hm...
I think we can use tools to distinguish Future from mock.
Hover will show which method is invoked.

I don't care much about "then" or "do", but I think Mockito developers have had
some reasons to choose such names. It would also simplify migration of our tests
or (maybe) adoption from other users of Mockito.

[devoncarew, 2014-04-24 16:50:51]

I was thinking more casual scanning of code. Futures are heavily used in Dart,
and:

  foo.then(() => bar());

is only subtly different from:

  foo.then((_) => bar())

It's probably only the bare 'then' method that would have this issue.
Disambiguating it a little bit from Future.then can't hurt :)

[scheglov, 2014-04-24 20:22:46]

Committed patchset #1 manually as r35399 (presubmit successful).