Issue 252393007: Make sure handler errors won't bring down a shelf server.

Issue 252393007: Make sure handler errors won't bring down a shelf server. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure handler errors won't bring down a shelf server. Also add more documentation to the README. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=35436

Patch Set 2 : code review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -11 lines)			Patch
M	pkg/shelf/CHANGELOG.md	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/shelf/README.md	View		1 chunk	+87 lines, -0 lines	0 comments	Download
M	pkg/shelf/lib/shelf_io.dart	View	1	3 chunks	+21 lines, -10 lines	0 comments	Download
M	pkg/shelf/lib/src/util.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/test/shelf_io_test.dart	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

On 2014/04/24 20:37:04, nweiz wrote: One question and one nit about a reference to hijack, ...

6 years, 8 months ago (2014-04-25 13:12:58 UTC) #2

kevmoo

https://codereview.chromium.org/252393007/diff/1/pkg/shelf/README.md File pkg/shelf/README.md (right): https://codereview.chromium.org/252393007/diff/1/pkg/shelf/README.md#newcode38 pkg/shelf/README.md:38: A [handler][] is any function that handles a [shelf.Request][] ...

6 years, 8 months ago (2014-04-25 13:13:06 UTC) #3

nweiz

Committed patchset #2 manually as r35436 (presubmit successful).

6 years, 8 months ago (2014-04-25 18:17:30 UTC) #4

nweiz

6 years, 8 months ago (2014-04-25 18:18:12 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/252393007/diff/1/pkg/shelf/README.md
File pkg/shelf/README.md (right):

https://codereview.chromium.org/252393007/diff/1/pkg/shelf/README.md#newcode38
pkg/shelf/README.md:38: A [handler][] is any function that handles a
[shelf.Request][] and returns a
On 2014/04/25 13:13:06, kevmoo wrote:
> Whats w/ the []?

It's markdown; it means "link this to the reference with the same name below".
It's useful when the URLs are long enough that they'd be distracting in the
text.

https://codereview.chromium.org/252393007/diff/1/pkg/shelf/lib/shelf_io.dart
File pkg/shelf/lib/shelf_io.dart (right):

https://codereview.chromium.org/252393007/diff/1/pkg/shelf/lib/shelf_io.dart#...
pkg/shelf/lib/shelf_io.dart:10: /// The `dart:io` adapter supports request
hijacking; see [Request.hijack].
On 2014/04/25 13:13:06, kevmoo wrote:
> Not yet?

Merge error, removed.

Expand Messages | Collapse Messages