Issue 252373003: Rework some analysis server tests using mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252373003: Rework some analysis server tests using mocks. (Closed)

Created:
6 years, 8 months ago by Paul Berry

Modified:
6 years, 8 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rework some analysis server tests using mocks. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=35374

Patch Set 2 : Mock Sources too. #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
	M	pkg/analysis_server/test/analysis_server_test.dart	View	1	7 chunks	+22 lines, -25 lines	0 comments	Download
	M	pkg/analysis_server/test/mocks.dart	View	1	2 chunks	+13 lines, -8 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm https://codereview.chromium.org/252373003/diff/20001/pkg/analysis_server/test/mocks.dart File pkg/analysis_server/test/mocks.dart (right): https://codereview.chromium.org/252373003/diff/20001/pkg/analysis_server/test/mocks.dart#newcode189 pkg/analysis_server/test/mocks.dart:189: @proxy Why do we need @proxy here?

6 years, 8 months ago (2014-04-24 05:56:24 UTC) #2

Paul Berry

Committed patchset #2 manually as r35374 (presubmit successful).

6 years, 8 months ago (2014-04-24 15:05:15 UTC) #3

Paul Berry

https://codereview.chromium.org/252373003/diff/20001/pkg/analysis_server/test/mocks.dart File pkg/analysis_server/test/mocks.dart (right): https://codereview.chromium.org/252373003/diff/20001/pkg/analysis_server/test/mocks.dart#newcode189 pkg/analysis_server/test/mocks.dart:189: @proxy On 2014/04/24 05:56:25, scheglov wrote: > Why do ...

6 years, 8 months ago (2014-04-24 15:05:25 UTC) #4

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages

Issue 252373003: Rework some analysis server tests using mocks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Mock Sources too. #

Messages