Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 25235002: When visiting arguments in the resolver, always set the [sendIsPropertyAccess] to false. (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

When visiting arguments in the resolver, always set the [sendIsPropertyAccess] to false. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=28044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A tests/language/issue13673_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-09-30 09:05:00 UTC) #1
karlklose
LGTM.
7 years, 2 months ago (2013-09-30 09:12:22 UTC) #2
ngeoffray
7 years, 2 months ago (2013-09-30 10:11:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698