Issue 2521383002: Correctly indent the RHS of 'is' and 'as' expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2521383002: Correctly indent the RHS of 'is' and 'as' expressions. (Closed)

Created:
4 years, 1 month ago by Bob Nystrom

Modified:
4 years, 1 month ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Correctly indent the RHS of 'is' and 'as' expressions. I'm surprised this has been wrong for so long. R=kevmoo@google.com Committed: https://github.com/dart-lang/dart_style/commit/34d6ff3653230898e6d653f0d1f3e067906cf4e4

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1 line)			Patch
M	CHANGELOG.md	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/source_visitor.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/splitting/mixed.stmt	View	1 chunk	+13 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

4 years, 1 month ago (2016-11-22 23:11:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
34d6ff3653230898e6d653f0d1f3e067906cf4e4 (presubmit successful).