Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 251523002: Improve error-recovery from unmatched braces. (Closed)

Created:
6 years, 8 months ago by ahe
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Improve error-recovery from unmatched braces. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35372

Patch Set 1 #

Patch Set 2 : Updated parser_test.dart #

Total comments: 1

Patch Set 3 : Merged with r35370 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -39 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart View 2 chunks +28 lines, -14 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 2 chunks +24 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/scanner.dart View 1 chunk +55 lines, -21 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/token.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_test.dart View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
This is actually what I need for Try Dart :-) I discovered, what I think ...
6 years, 8 months ago (2014-04-24 12:43:34 UTC) #1
Johnni Winther
lgtm
6 years, 8 months ago (2014-04-24 13:07:29 UTC) #2
ahe
Thanks for looking out for tests, Luke! https://codereview.chromium.org/251523002/diff/20001/dart/sdk/lib/_internal/compiler/implementation/warnings.dart File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/251523002/diff/20001/dart/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode1775 dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1775: "main(){]}", These ...
6 years, 8 months ago (2014-04-24 13:08:32 UTC) #3
ahe
6 years, 8 months ago (2014-04-24 14:48:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698