Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251373012: Add Heap::isolate_ to simplify code. (Closed)

Created:
6 years, 8 months ago by koda
Modified:
6 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add Heap::isolate_ to simplify code. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35434

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -57 lines) Patch
M runtime/vm/heap.h View 4 chunks +13 lines, -7 lines 0 comments Download
M runtime/vm/heap.cc View 15 chunks +28 lines, -37 lines 0 comments Download
M runtime/vm/pages.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/pages.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/scavenger_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 8 months ago (2014-04-24 23:56:52 UTC) #1
Ivan Posva
LGTM after removing the Isolate::Current() calls in the scavenger. -Ivan https://codereview.chromium.org/251373012/diff/20001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/251373012/diff/20001/runtime/vm/heap.cc#newcode348 ...
6 years, 8 months ago (2014-04-25 16:55:57 UTC) #2
koda
Updated scavenger.cc; submitting. https://codereview.chromium.org/251373012/diff/20001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/251373012/diff/20001/runtime/vm/heap.cc#newcode348 runtime/vm/heap.cc:348: this->GetMergedAddressRange(&start, &end); On 2014/04/25 16:55:57, Ivan ...
6 years, 8 months ago (2014-04-25 17:26:06 UTC) #3
koda
6 years, 8 months ago (2014-04-25 17:49:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r35434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698