Issue 251373006: Fix dart2js replace to escape all dollar characters in the replacement string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251373006: Fix dart2js replace to escape all dollar characters in the replacement string. (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
floitsch, herhut

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix dart2js replace to escape all dollar characters in the replacement string. BUG= http://dartbug.com/17886 R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=35516

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	sdk/lib/_internal/lib/string_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/corelib/string_replace_dollar_test.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-04-29 08:02:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r35516 (presubmit successful).