Issue 251083007: Removes loads from PP from stubs on arm64.

Issue 251083007: Removes loads from PP from stubs on arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Removes loads from PP from stubs on arm64. Also fixes a bug in loads and stores. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35537

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -65 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	10 chunks	+18 lines, -17 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/runtime_entry_arm64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	36 chunks	+47 lines, -44 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/251083007/diff/1/runtime/vm/runtime_entry_arm64.cc File runtime/vm/runtime_entry_arm64.cc (right): https://codereview.chromium.org/251083007/diff/1/runtime/vm/runtime_entry_arm64.cc#newcode47 runtime/vm/runtime_entry_arm64.cc:47: __ LoadImmediate(R5, entry, kNoRegister); These kNoRegister all over ...

6 years, 7 months ago (2014-04-29 18:25:57 UTC) #2

zra

Thanks! https://codereview.chromium.org/251083007/diff/1/runtime/vm/runtime_entry_arm64.cc File runtime/vm/runtime_entry_arm64.cc (right): https://codereview.chromium.org/251083007/diff/1/runtime/vm/runtime_entry_arm64.cc#newcode47 runtime/vm/runtime_entry_arm64.cc:47: __ LoadImmediate(R5, entry, kNoRegister); On 2014/04/29 18:25:57, regis ...

6 years, 7 months ago (2014-04-29 19:07:45 UTC) #3

zra

6 years, 7 months ago (2014-04-29 19:08:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35537 (presubmit successful).

Expand Messages | Collapse Messages