Issue 25099003: Make the implementations of InstanceMirror.hashCode use dart:core's identityHashCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25099003: Make the implementations of InstanceMirror.hashCode use dart:core's identityHashCode. (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, ahe, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the implementations of InstanceMirror.hashCode use dart:core's identityHashCode. R=ahe@google.com, lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=28229

Patch Set 2 : rebase #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -34 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		1 chunk	+1 line, -11 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View		1 chunk	+1 line, -10 lines	0 comments	Download
A	tests/corelib/hashcode_boxed_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/25099003/diff/7001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/25099003/diff/7001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1 sdk/lib/_internal/lib/js_mirrors.dart:1: // Copyright (c) 2013, the Dart project authors. Please ...

7 years, 2 months ago (2013-10-03 09:05:40 UTC) #4

rmacnak

7 years, 2 months ago (2013-10-03 16:38:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28229 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25099003: Make the implementations of InstanceMirror.hashCode use dart:core's identityHashCode. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : rebase #

Messages