Make ClassMirror.newInstance deal with reordered etc type arguments for redirecting factories.

Make ClassMirror.newInstance deal with reordered etc type arguments for redirecting factories.

BUG=http://dartbug.com/11781
BUG=http://dartbug.com/13365
R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28106

[regis, 2013-09-28 01:11:40]

LGTM

https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
File tests/lib/mirrors/redirecting_factory_test.dart (right):

https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
tests/lib/mirrors/redirecting_factory_test.dart:17: factory
Class.redirectingFactoryUnnamedOptional(a, [b = 5]) =
This will become illegal very soon. But why the change?

https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
tests/lib/mirrors/redirecting_factory_test.dart:20: factory
Class.factoryNamedOptional(a, {b: 42}) {
Why?

https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
tests/lib/mirrors/redirecting_factory_test.dart:24: factory
Class.redirectingFactoryNamedOptional(a, {b: 5}) =
Illegal soon.

[rmacnak, 2013-09-30 16:33:05]

On 2013/09/28 01:11:40, regis wrote:
> LGTM
> 
>
https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
> File tests/lib/mirrors/redirecting_factory_test.dart (right):
> 
>
https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
> tests/lib/mirrors/redirecting_factory_test.dart:17: factory
> Class.redirectingFactoryUnnamedOptional(a, [b = 5]) =
> This will become illegal very soon. But why the change?
> 
>
https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
> tests/lib/mirrors/redirecting_factory_test.dart:20: factory
> Class.factoryNamedOptional(a, {b: 42}) {
> Why?
> 
>
https://codereview.chromium.org/25097005/diff/6001/tests/lib/mirrors/redirect...
> tests/lib/mirrors/redirecting_factory_test.dart:24: factory
> Class.redirectingFactoryNamedOptional(a, {b: 5}) =
> Illegal soon.

The named-optional and positional-optional cases in the test were inconsistent.
Also a default value 0 didn't separate out the possibility that a parameter was
unused by itself, although that's a bit over the top.

[rmacnak, 2013-09-30 19:44:05]

PTAL at revised tests

[regis, 2013-10-01 18:01:53]

LGTM

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/lib/mirror...
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/lib/mirror...
runtime/lib/mirrors.cc:1426: Error& malformed_error = Error::Handle();
Actually, this can only be a bound_error, not malformed_error. You probably copy
pasted this from a source that I have not fixed yet. I'll do a pass later and
fix these.

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/vm/dart_ap...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/vm/dart_ap...
runtime/vm/dart_api_impl.cc:2892: Error& malformed_error = Error::Handle();
ditto

[rmacnak, 2013-10-01 18:23:12]

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/lib/mirror...
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/25097005/diff/14001/runtime/lib/mirror...
runtime/lib/mirrors.cc:1426: Error& malformed_error = Error::Handle();
On 2013/10/01 18:01:53, regis wrote:
> Actually, this can only be a bound_error, not malformed_error. You probably
copy
> pasted this from a source that I have not fixed yet. I'll do a pass later and
> fix these.

Done. Was from the parser code for new.

[rmacnak, 2013-10-01 18:23:29]

Committed patchset #6 manually as r28106 (presubmit successful).