Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 25092010: Adds the BreakpointRuntime stub to ARM and MIPS. (Closed)

Created:
7 years, 2 months ago by zra
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds the BreakpointRuntime stub to ARM and MIPS. Also: - Makes some stub calls patachable. - Updates pkg.status for an unrelated failing test. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28066

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M pkg/pkg.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 1 chunk +16 lines, -1 line 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
This is the fix for: https://code.google.com/p/dart/issues/detail?id=13690
7 years, 2 months ago (2013-09-30 18:48:28 UTC) #1
Florian Schneider
dbc: Thanks for fixing this! https://codereview.chromium.org/25092010/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/25092010/diff/1/runtime/vm/stub_code_mips.cc#newcode2006 runtime/vm/stub_code_mips.cc:2006: __ sw(S5, Address(SP, 2 ...
7 years, 2 months ago (2013-09-30 18:57:59 UTC) #2
regis
LGTM
7 years, 2 months ago (2013-09-30 19:52:17 UTC) #3
zra
https://codereview.chromium.org/25092010/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/25092010/diff/1/runtime/vm/stub_code_mips.cc#newcode2006 runtime/vm/stub_code_mips.cc:2006: __ sw(S5, Address(SP, 2 * kWordSize)); On 2013/09/30 18:57:59, ...
7 years, 2 months ago (2013-09-30 20:17:15 UTC) #4
zra
7 years, 2 months ago (2013-09-30 20:17:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r28066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698