verifyNoMoreInteractions() and verifyZeroInteractions()

verifyNoMoreInteractions() and verifyZeroInteractions()

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=35441

[Paul Berry, 2014-04-25 17:46:41]

lgtm

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
File pkg/analysis_server/test/typed_mock.dart (right):

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/typed_mock.dart:40: if (mock is! TypedMock) {
Why not just make the function signature "void
verifyNoMoreInteractions(TypedMock mock)?

A similar comment applies to verifyZeroInteractions().

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/typed_mock.dart:45: var unexpected = <Invocation> [];
Nit: this could be more compact as:

var unexpected = typedMock._invocations.where((invocation) =>
!typedMock._verifiedInvocations.contains(invocation)).toList();

[scheglov, 2014-04-25 18:25:52]

PTAL

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
File pkg/analysis_server/test/typed_mock.dart (right):

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/typed_mock.dart:40: if (mock is! TypedMock) {
On 2014/04/25 17:46:41, Paul Berry wrote:
> Why not just make the function signature "void
> verifyNoMoreInteractions(TypedMock mock)?
> 
> A similar comment applies to verifyZeroInteractions().

This would not allow us to write:

Source source = new SourceMock();
verifyZeroInteractions(source);

I don't know if we want to carry Mock suffix everywhere in our tests.
But given that we recommended style is:

var source = new SourceMock();
verifyZeroInteractions(source);

...it seems that it doesn't matter.

So, done.

https://codereview.chromium.org/250813003/diff/20001/pkg/analysis_server/test...
pkg/analysis_server/test/typed_mock.dart:45: var unexpected = <Invocation> [];
On 2014/04/25 17:46:41, Paul Berry wrote:
> Nit: this could be more compact as:
> 
> var unexpected = typedMock._invocations.where((invocation) =>
> !typedMock._verifiedInvocations.contains(invocation)).toList();

Yes, we could.
But formatted it looks like a mess.

I could accept it if it were formatted as:

  var unexpected = mock._invocations
        .where((invocation) => !mock._verifiedInvocations.contains(invocation))
        .toList();

But even then, I think the filter is longer than it is convenient to read.

Hm...
It could be a sign that we need a better design here.

Such as:
var unexpected = mock._invocations.where(mock._isNotVerified).toList();

Or... even it should be a function in Mock that returns its not verified
invocations.

Done.

[Paul Berry, 2014-04-25 19:08:18]

lgtm

[scheglov, 2014-04-25 19:18:32]

Committed patchset #3 manually as r35441 (presubmit successful).

[Brian Wilkerson, 2014-04-26 16:40:02]

LGTM