Issue 250573002: Change the badly named RegExp.pattern to return the original source.

Issue 250573002: Change the badly named RegExp.pattern to return the original source. (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:
floitsch, sigurdm

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the badly named RegExp.pattern to return the original source. On dart2js, it returned the .source property of the underlying JS regexp, which may not be the same (e.g., for "/" and ""). BUG= http://dartbug.com/17998 R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=35368

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update date. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -12 lines)			Patch
M	sdk/lib/_internal/lib/regexp_helper.dart	View		4 chunks	+12 lines, -11 lines	0 comments	Download
M	sdk/lib/core/regexp.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/corelib/reg_exp_pattern_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sigurdm

lgtm https://codereview.chromium.org/250573002/diff/1/tests/corelib/reg_exp_pattern_test.dart File tests/corelib/reg_exp_pattern_test.dart (right): https://codereview.chromium.org/250573002/diff/1/tests/corelib/reg_exp_pattern_test.dart#newcode1 tests/corelib/reg_exp_pattern_test.dart:1: // Copyright (c) 2011, the Dart project authors. ...

6 years, 8 months ago (2014-04-24 11:36:42 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #2 manually as r35368 (presubmit successful).

6 years, 8 months ago (2014-04-24 12:33:37 UTC) #3

Lasse Reichstein Nielsen

https://codereview.chromium.org/250573002/diff/1/tests/corelib/reg_exp_pattern_test.dart File tests/corelib/reg_exp_pattern_test.dart (right): https://codereview.chromium.org/250573002/diff/1/tests/corelib/reg_exp_pattern_test.dart#newcode1 tests/corelib/reg_exp_pattern_test.dart:1: // Copyright (c) 2011, the Dart project authors. Please ...

6 years, 8 months ago (2014-04-24 12:38:10 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages