Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 25050004: Add a is_recognized bit to function kind field. Improves performance of method recognizer and thus … (Closed)

Created:
7 years, 2 months ago by srdjan
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a is_recognized bit to function kind field. Improves performance of method recognizer and thus the compilation speed. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28026

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -10 lines) Patch
runtime/vm/intermediate_language.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
runtime/vm/intermediate_language.cc View 1 2 3 4 5 3 chunks +22 lines, -3 lines 0 comments Download
runtime/vm/object.h View 1 2 3 4 4 chunks +13 lines, -1 line 0 comments Download
runtime/vm/object.cc View 1 2 3 4 4 chunks +14 lines, -5 lines 0 comments Download
runtime/vm/raw_object.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 2 months ago (2013-09-27 19:46:26 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-09-27 20:49:23 UTC) #2
srdjan
7 years, 2 months ago (2013-09-27 21:01:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r28026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698