Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 25010004: Add .address to [Raw]ServerSocket and HttpServer. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add .address to [Raw]ServerSocket and HttpServer. Also use .address in Pub's barback server. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28010

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Remove 'host' arg from BarbackServer constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M runtime/bin/socket_patch.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/server.dart View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M sdk/lib/io/http.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/socket.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M tests/standalone/io/http_server_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/standalone/io/socket_ipv6_test.dart View 7 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-09-27 10:26:16 UTC) #1
Søren Gjesse
lgtm
7 years, 2 months ago (2013-09-27 10:38:11 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-09-27 13:36:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28010 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698