Issue 250073002: Re-apply "Add a non-dart:io WebSocket implementation to http_parser."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250073002: Re-apply "Add a non-dart:io WebSocket implementation to http_parser." (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-apply "Add a non-dart:io WebSocket implementation to http_parser." Re-apply "Fix an analyzer error in http_parser's WebSocket implementation." This also marks the web socket test as failing on dart2js nad the browser. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=35330

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+309 lines, -236 lines)			Patch
A	pkg/http_parser/CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/http_parser/lib/http_parser.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	pkg/http_parser/lib/src/bytes_builder.dart	View	1 chunk	+9 lines, -1 line	0 comments	Download
A +	pkg/http_parser/lib/src/web_socket.dart	View	19 chunks	+197 lines, -234 lines	0 comments	Download
M	pkg/http_parser/pubspec.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	pkg/http_parser/test/web_socket_test.dart	View	1 chunk	+95 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

On 2014/04/23 19:37:47, nweiz wrote: TBR at Kevin's request.

6 years, 8 months ago (2014-04-23 20:53:10 UTC) #2

nweiz

Committed patchset #1 manually as r35330 (presubmit successful).

6 years, 8 months ago (2014-04-23 20:53:24 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages