Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 24983003: Use const instead of runtime type for equality of EmptyExpression. (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use const instead of runtime type for equality of EmptyExpression. R=jmesserly@google.com, justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=28042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/polymer_expressions/lib/expression.dart View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ngeoffray
This was motivated by a hint given by dart2js (when doing build.py) that there is ...
7 years, 2 months ago (2013-09-27 07:55:35 UTC) #1
kasperl
Adding Justin as a reviewer too.
7 years, 2 months ago (2013-09-27 07:58:21 UTC) #2
kasperl
7 years, 2 months ago (2013-09-27 07:58:48 UTC) #3
justinfagnani
lgtm const is fine for this. Thanks!
7 years, 2 months ago (2013-09-27 19:14:59 UTC) #4
Jennifer Messerly
lgtm too, thank you Nicolas!
7 years, 2 months ago (2013-09-27 19:21:58 UTC) #5
ngeoffray
7 years, 2 months ago (2013-09-30 06:37:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r28042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698