Issue 24973002: Use SIGKILL in scheduled_process, to get around an Mac OS X bug.

Issue 24973002: Use SIGKILL in scheduled_process, to get around an Mac OS X bug. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
ricow1, Bob Nystrom, Søren Gjesse, nweiz

CC:
reviews_dartlang.org, nweiz, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use SIGKILL in scheduled_process, to get around an Mac OS X bug. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27986

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	pkg/scheduled_test/lib/scheduled_process.dart	View		3 chunks	+7 lines, -3 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r27986 (presubmit successful).

7 years, 2 months ago (2013-09-27 06:47:20 UTC) #3

Bob Nystrom

https://codereview.chromium.org/24973002/diff/1/pkg/scheduled_test/lib/scheduled_process.dart File pkg/scheduled_test/lib/scheduled_process.dart (right): https://codereview.chromium.org/24973002/diff/1/pkg/scheduled_test/lib/scheduled_process.dart#newcode22 pkg/scheduled_test/lib/scheduled_process.dart:22: /// SIGTERM on Mac OS X may be ignore). ...

7 years, 2 months ago (2013-09-27 18:03:53 UTC) #4

nweiz

In future, please add Bob and me as reviewers on any changes to code we ...

7 years, 2 months ago (2013-09-27 19:34:32 UTC) #5

Anders Johnsen

7 years, 2 months ago (2013-09-30 14:59:55 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/25278003

https://codereview.chromium.org/24973002/diff/1/pkg/scheduled_test/lib/schedu...
File pkg/scheduled_test/lib/scheduled_process.dart (right):

https://codereview.chromium.org/24973002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_process.dart:22: /// SIGTERM on Mac OS X may be
ignore).
On 2013/09/27 18:03:54, Bob Nystrom wrote:
> "ignore" -> "ignored".

Nice catch, fixed.

Expand Messages | Collapse Messages