Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 24964002: Use SIGKILL in regress_7191_script. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use SIGKILL in regress_7191_script. This makes the test pass on Mac OS X, that contains a bug for dealing with early SIGTERM signals. BUG=https://code.google.com/p/dart/issues/detail?id=13637 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27985

Patch Set 1 #

Patch Set 2 : add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tests/standalone/io/regress_7191_script.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-09-27 05:38:49 UTC) #1
ricow1
LGTM
7 years, 2 months ago (2013-09-27 06:00:51 UTC) #2
Ivan Posva
Can you please elaborate what you mean with the early SIGTERM bug? Maybe add a ...
7 years, 2 months ago (2013-09-27 06:15:24 UTC) #3
Anders Johnsen
Sure thing, added! Cheers, - Anders
7 years, 2 months ago (2013-09-27 06:28:05 UTC) #4
Anders Johnsen
7 years, 2 months ago (2013-09-27 06:28:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698