Issue 249553003: Connect heap map to instance view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249553003: Connect heap map to instance view. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Connect heap map to instance view. Clicking anywhere on the heap map sends an 'address' message to look up the object spanning the corresponding address. Also fix issue with free list elements (which cannot be wrapped in handles). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35315

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	runtime/bin/vmservice/client/lib/src/elements/heap_map.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	runtime/vm/service.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 8 months ago (2014-04-23 17:00:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35315 (presubmit successful).

Expand Messages | Collapse Messages