Issue 24952003: Change TypeMask.base to be a ClassElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24952003: Change TypeMask.base to be a ClassElement. (Closed)

Created:
7 years, 2 months ago by kasperl

Modified:
7 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change TypeMask.base to be a ClassElement. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27990

Patch Set 1 #

Patch Set 2 : Declaration! #

Patch Set 3 : Moar declaration. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -350 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View	1 2	5 chunks	+12 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/bailout.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		7 chunks	+11 lines, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1	17 chunks	+36 lines, -57 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View	1	14 chunks	+53 lines, -71 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/forwarding_type_mask.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View		3 chunks	+12 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/types.dart	View		17 chunks	+61 lines, -58 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart	View		6 chunks	+8 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/function_set.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/cpa_inference_test.dart	View		3 chunks	+15 lines, -15 lines	0 comments	Download
M	tests/compiler/dart2js/field_type_simple_inferer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/patch_test.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_closure_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_try_catch_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View		3 chunks	+20 lines, -20 lines	0 comments	Download
M	tests/compiler/dart2js/union_type_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

7 years, 2 months ago (2013-09-27 07:44:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r27990 (presubmit successful).

Expand Messages | Collapse Messages