Issue 24944003: Prefix compile-time typedef checks with __attribute__((unused))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24944003: Prefix compile-time typedef checks with attribute((unused)) (Closed)

Created:
7 years, 2 months ago by Chris Bracken

Modified:
7 years, 2 months ago

Reviewers:
iposva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Prefix compile-time typedef checks with __attribute__((unused)) Prevents build failure under gcc 4.8. Bug report: http://dartbug.com/13645 BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28411

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	runtime/platform/assert.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	runtime/platform/globals.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

LGTM, but please pull it out into its own define similarly to DART_FORCE_INLINE. -Ivan

7 years, 2 months ago (2013-09-30 02:28:55 UTC) #2

Chris Bracken

7 years, 2 months ago (2013-10-09 19:43:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r28411 (presubmit successful).