Issue 249183005: Move common streams in barback to their own class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249183005: Move common streams in barback to their own class. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Move common streams in barback to their own class. This cleans up some duplication and will make it easier to change or add common streams in the future. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35341

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -112 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	5 chunks	+9 lines, -15 lines	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/barback/lib/src/node_streams.dart	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View	8 chunks	+14 lines, -30 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	4 chunks	+11 lines, -26 lines	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	12 chunks	+17 lines, -41 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

6 years, 8 months ago (2014-04-23 22:58:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35341 (presubmit successful).