Issue 24918003: Revert "Revert "Reinstate type checks in Math.min and Math.max""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24918003: Revert "Revert "Reinstate type checks in Math.min and Math.max"" (Closed)

Created:
7 years, 2 months ago by sra1

Modified:
7 years, 2 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Revert "Reinstate type checks in Math.min and Math.max"" Committed: https://code.google.com/p/dart/source/detail?r=27983

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -2 lines)			Patch
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/math/math.dart	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	tests/lib/math/min_max_test.dart	View	1	3 chunks	+35 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sra1

Committed patchset #2 manually as r27983 (presubmit successful).

7 years, 2 months ago (2013-09-27 02:01:47 UTC) #1

Ivan Posva

7 years, 2 months ago (2013-09-27 06:33:50 UTC) #2

Message was sent while issue was closed.

On 2013/09/27 02:01:47, sra1 wrote:
> Committed patchset #2 manually as r27983 (presubmit successful).

No reviewers?

-Ivan