Int switch

Int switch

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35311

[Anders Johnsen, 2014-04-23 11:57:04]

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:347: _addDate(this, name, value);
Should we merge return into this line?

[Søren Gjesse, 2014-04-23 12:06:39]

lgtm

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:343: assert(name == name.toLowerCase());
Please add a comment on this optimization.

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:347: _addDate(this, name, value);
On 2014/04/23 11:57:05, Anders Johnsen wrote:
> Should we merge return into this line?

Don't think so.

[Anders Johnsen, 2014-04-23 12:20:12]

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/249083004/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:343: assert(name == name.toLowerCase());
On 2014/04/23 12:06:39, Søren Gjesse wrote:
> Please add a comment on this optimization.

Done.

[Anders Johnsen, 2014-04-23 12:21:07]

Committed patchset #3 manually as r35311 (presubmit successful).

[Lasse Reichstein Nielsen, 2014-04-23 12:31:05]

Slow LGTM

https://codereview.chromium.org/249083004/diff/40001/sdk/lib/io/http_headers....
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/249083004/diff/40001/sdk/lib/io/http_headers....
sdk/lib/io/http_headers.dart:304: void _addContentLength(String name, value) {
Do you need to pass the name?
It should always be HttpHeaders.CONTENT_LENGTH here (and it isn't even used in
this function).

https://codereview.chromium.org/249083004/diff/40001/sdk/lib/io/http_headers....
sdk/lib/io/http_headers.dart:314: void _addTransferEncoding(String name, value)
{
Consider sorting functions by name?

[Anders Johnsen, 2014-04-23 12:33:00]

https://codereview.chromium.org/249083004/diff/40001/sdk/lib/io/http_headers....
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/249083004/diff/40001/sdk/lib/io/http_headers....
sdk/lib/io/http_headers.dart:304: void _addContentLength(String name, value) {
On 2014/04/23 12:31:06, Lasse Reichstein Nielsen wrote:
> Do you need to pass the name?
> It should always be HttpHeaders.CONTENT_LENGTH here (and it isn't even used in
> this function).

Yes, but as we use it a lot (see exception), it's cleaner to pass it.